Should I max this out?

I’ve been wanting a good one gengar and idk if I should evolve this. remember in a YouTube video I watched that he said it’s better if the “attack bar” is not full, can anyone explain that to me if it’s correct or not